Google Git
Sign in
chromium / chromium / src / 6f0da5e7b86e83fe5fa7a62c372c62a3c0f16449
commit6f0da5e7b86e83fe5fa7a62c372c62a3c0f16449[log] [tgz]
authorMikel Astiz <mastiz@chromium.org>Wed May 01 21:05:20 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 01 21:05:20 2024
treeeb97e3baa784a471e9ab40a5844f7d78f2dbeaa4
parentaa12c80a9b321929565152e12373298b0d191bba [diff]
[M125][bookmark] Fix crash if local folder with children is moved to account

If the moved node is a folder and the node became syncable as a result
of the move at hands (i.e. uploaded to account), not only the folder
needs to be treated as a creation but the same must be done for all
descendents to avoid later crashes (due to invariant violations).

In this patch, a new function recursively iterates through all
descendents to ensure that all nodes being moved become tracked, which
is precisely what the invariant requires.

(cherry picked from commit 65e4bd8456a0f5675300f55c4b9d6dfbaf756d6e)

Change-Id: I5c38ad38d2f63053d1d146e4f1c788b719ca743d
Fixed: 338064635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503390
Commit-Queue: Brandon Wylie <wylieb@google.com>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@google.com>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1294591}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5506253
Cr-Commit-Position: refs/branch-heads/6422@{#567}
Cr-Branched-From: 9012208d0ce02e0cf0adb9b62558627c356f3278-refs/heads/main@{#1287751}
4 files changed
tree: eb97e3baa784a471e9ab40a5844f7d78f2dbeaa4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.