Google Git
Sign in
chromium / chromium / src / 6f241146843f2a8ac230841d5d6585832911abd4
commit6f241146843f2a8ac230841d5d6585832911abd4[log] [tgz]
authorLijin Shen <lazzzis@google.com>Wed Jun 07 20:59:20 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 07 20:59:20 2023
treef6fdc11dc21142d1c16f93729f2b37686a695f05
parentbcbdde8710e25aad7dd52f2d16e0ac08cfa708cb [diff]
Observe back press state change with navigationStateChanged

Through TabObserve.onUrlUpdated & onTitleUpdated, we already observed
InvalidateTypes.Title and Url changes. This CL adds other types
observation, i.e: InvalidateTypes.Load and InvalidateTypes.Tab.

This CL is a speculative fix to back press refactor change as
we missed some signals of tab's back press state changed.
navigationStateChanged is supposed to be triggered as long as any navigation related change occurs in the navigation_controller_impl.cc.

Since load state is also observed through WebContentsObserver methods,
like WebContentsObserver.didStartLoading, new methods are behind
flags in order to observe the differences and avoid potential
performance cost.

This is also to mirror how the desktop side observes and updates the
toolbar back button.
https://source.chromium.org/chromium/chromium/src/+/refs/heads/main:chrome/browser/ui/browser.cc;l=1654;drc=66941d1f0cfe9155b400aef887fe39a403c1f518

Bug: 1433481, 1450625
Change-Id: Ia58b3074e995707bcbc907ab8ae01a6043811ebd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4592011
Commit-Queue: Lijin Shen <lazzzis@google.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1154604}
6 files changed
tree: f6fdc11dc21142d1c16f93729f2b37686a695f05
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.