Google Git
Sign in
chromium / chromium / src / 6f5284f6f7f1ebc8b34a8516ae64680adc46f9d5
commit6f5284f6f7f1ebc8b34a8516ae64680adc46f9d5[log] [tgz]
authorNicolas MacBeth <nicolasmacbeth@google.com>Tue Jun 11 21:49:10 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 11 21:49:10 2024
tree28fd977aad7a4e0ec0006a8e85cd74903ed72bfe
parent9936b957730ff216a603e2de600bf4ebc89766d8 [diff]
[iOS] Improved ignoring outside interactions for in-product help bubbles

Made improvements to ignoring taps outside the bubbles by only ignoring
taps that are inside the web content area. This way, clients don't need
to add a slew of edge case dismissal commands, such as dismissing the
bubble when entering the tab grid, clicking the omnibox, or opening
the overflow menu.

Bug: 344960790
Change-Id: I08a87f00ecdb00ffe8e70a8f1bf8a8051f996d9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5605042
Commit-Queue: Nicolas MacBeth <nicolasmacbeth@google.com>
Reviewed-by: Ginny Huang <ginnyhuang@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1313686}
3 files changed
tree: 28fd977aad7a4e0ec0006a8e85cd74903ed72bfe
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.