Combine Frame IPC's CreateNewWindow and ShowCreatedWindow Prior to this CL, popping up a new window involved two renderer->browser IPC's: CreateNewWindow(), which is sync; and ShowCreatedWindow(), which is not sync. In addition to the linked bug, this arrangement requires some awkward architecture in the window-creating code. This CL combines the two IPC's into a single sync IPC. There are a few failure scenarios that currently prevent ShowCreatedWindow() from running after CreateNewWindow(); but those failure conditions are known to the browser at the time the reply to CreateNewWindow() is sent, so the browser code can act accordingly. The new behavior is behind an enabled-by-default feature flag, to give it an easy kill switch in case of breakage. Bug: chromium:41099297 Change-Id: I0c67de461d0f646085e13cab25114cfe1b150139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6343761 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#1435113}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.