Google Git
Sign in
chromium / chromium / src / 6fa01835e9ca70d04c375fd8fb4f6f625a262929
commit6fa01835e9ca70d04c375fd8fb4f6f625a262929[log] [tgz]
authorRoman Arora <romanarora@chromium.org>Wed Dec 01 00:25:41 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Dec 01 00:25:41 2021
treef82e3f5d792c9902d1ae1406b67b3edf3ba1bc75
parentde08782b04147d8ef733ce6d05a674bc4e3e7041 [diff]
[Side Search] Leverage protobuff data types for state restore.

Replaces usage of the base::Value data type in favor of custom side
search specific protobuff data types that are serialized/deserialized as
strings. By leveraging protobuff, we can leverage its capabilities when
it comes to data versioning and reduce developer complexity that may
arise when needing to support changing data types.

This was proposed while discussing the related CL (see below). The
protobuff types will be leveraged too for serializing and deserialing
extra_data in pickle data.

See:
https://docs.google.com/document/d/1vnCNPDGY5MQNND0_q4HxrsGI9SvX47q8S2Bmkv05-Vo/

Related CL:
https://chromium-review.googlesource.com/c/chromium/src/+/3285933

Bug: 1262614
Change-Id: I335806ecf35a763a6b24f6d06b28570ceb2d3fcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307781
Commit-Queue: Roman Arora <romanarora@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#946779}
26 files changed
tree: f82e3f5d792c9902d1ae1406b67b3edf3ba1bc75
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.