commit | 6fba6bc04c583cb814a15c91f073efa2a30c29f6 | [log] [tgz] |
---|---|---|
author | Addison Luh <aluh@chromium.org> | Tue Aug 02 22:52:55 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Aug 02 22:52:55 2022 |
tree | fff6020a7014841ed7a2debc87b543d97333b3f6 | |
parent | 2a0b4beff9d3ac76c754815a2e33267faf881c49 [diff] |
[lacros] Add support for virtual keyboard occluded bounds. This change introduces a new wayland event for zwp_extended_text_input_v1 that sends the virtual keyboard occluded bounds to the client. This allows the lacros client to know the part of the window that is occluded by the virtual keyboard and make adjustments like scrolling the web content to make a text input visible. Design doc: go/lacros-vk-bounds The current implementation has 3 bugs that I will investigate further: * When changing focus from the omni-bar to a web content text input via mouse click, there's a race condition where the text input doesn't get focused sometimes. * While focusing on a web content text input, clicking on an element in the browser toolbar, like the Extensions icon, doesn't un-scroll the web content back after the vk closes, resulting in extra empty space where the vk used to be. * When changing focus back to a previously focused web content text input from the omni-bar or by closing popup menu, the web content will re-scroll unnecessarily. Bug: 1253006 Change-Id: Ibf3734a08403f1530733a08c1b6c93e7327ba038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3751738 Reviewed-by: Kramer Ge <fangzhoug@chromium.org> Commit-Queue: Addison Luh <aluh@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/main@{#1030796}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.