commit 6fd3dd505e019cc2c789aa050431f1b0970cf2ac
author Nathan Hebert <nhebert@chromium.org> Wed Apr 10 01:24:06 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Apr 10 01:24:06 2024
tree 73ec7195945c997e6d9e4833eca776acdb36b0b3
parent 636db10d74870b2befbfe41c95ad11a53db774dd

cast certificate: enable --cast-developer-certificate-path switch

Previously the Chrome command line switch,
--cast-developer-certificate-path, was only used if the build flag,
cast_allow_developer_certificate was set to true. This CL enables the
command line switch always. Doing so helps unblock testing on the CQ
and on ChromeOS. The change is in a few parts.

One change is to use the platform independent command line parsing
method: base::CommandLine::GetSwitchValuePath(). Doing so fixes
compilation on Windows where FilePath is constructed from std::wstring.

Another change is to gate starting a task to load the certificate file
by the presence of the command line switch. This avoids an issue where
the CastAuthUtilTest lacks a task environment. It is also a
micro-optimization.

Since build flag cast_allow_developer_certificate is no longer used, the
certificate BUILD.gn no longer include its definition from
third_party/openscreen.

This change also adds the --cast-developer-certificate-path switch to
the "bad flags" list, so a user will see a warning in the info bar if
the flag has been set.

A security review of always enabling the switch has been approved.

Bug: b:320187114
Test: Streamed to standalone cast_receiver with developer certificates

Change-Id: I5b8e70dd42e6fd39bd379213c6518ac66a3c9c32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5407786
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Nathan Hebert <nhebert@chromium.org>
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284833}