Google Git
Sign in
chromium / chromium / src / 6feb51178e9a8618f7e635f061ef685277f6923f
commit6feb51178e9a8618f7e635f061ef685277f6923f[log] [tgz]
authorZhenyao Mo <zmo@chromium.org>Thu Sep 12 20:52:29 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Sep 12 20:52:29 2024
tree2dc4da3c978a465269eb2d912e6c7be58c2d44e1
parent0e48cb85c89e5cf4f7691e63e0582d8614faa3a5 [diff]
[cc-slimming] Audit and fortify logic around all_tiles_done flags.

All cases that could cause a Tiling's all_tiles_done flag to be
updated are:

1) CopyTilingsAndPropertiesFromPendingTwin
2) UpdateTilingsToCurrentRasterSourceForCommit
3) UpdateTilingsToCurrentRasterSourceForActivation
4) Invalidate

In this CL, we recompute TilingSet's flag in all the above
four cases, so we don't need the awkward OnAllTilesDoneCleared()
wiring. Besides, previously we had multiple cases where
we set Tiling's all_tiles_done to false but without calling
OnAllTilesDoneCleared() and forwarding it to TilingSet. Now
it's all taken care of.

TEST=cc_unittests

Bug: 338977414
Change-Id: I6df0c27d01b03a6c1f3f1457ce3e12dd22c880c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5855942
Reviewed-by: Victor Miura <vmiura@chromium.org>
Auto-Submit: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1354804}
8 files changed
tree: 2dc4da3c978a465269eb2d912e6c7be58c2d44e1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitallowed
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. CPPLINT.cfg
  76. CRYPTO_OWNERS
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.