commit | 6ff3dcf0dfc3a5307ebe601f6b41ea4a99c64b56 | [log] [tgz] |
---|---|---|
author | Weizhong Xia <weizhong@google.com> | Tue May 03 05:10:43 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue May 03 05:10:43 2022 |
tree | 02bed74935df523ce4b14df844d640af2aa2c386 | |
parent | 780a212f3e473cae72cb03c18b8bd9977d764e5c [diff] |
Move all generic baselines to web_tests/platform/generic Notice to sheriffs: This is a huge CL. Test could fail if another CL creating baselines at old place landed at the same time. Please consider revert that CL. Please ping me if there are still issues. With this change, generic baselines are now put under web_tests/baselines/generic. Reference files can be put under baselines/generic, or at the same folder of the test. This is a first step to separate blink_wpt_tests out of blink_web_tests. With this change, all the wpt tests will be in external/wpt or wpt_internal, and their baselines will be always in baselines folder. This makes it easier for us to specify dependency. Here are the steps to create this CL: Step 1: make the changes in blink/tools and BUILD.gn, commit that to make first commit. Step 2: create folder for platform/generic, and run a set of commands to move all generic baselines to platform/generic. The commands for *-expected.txt are put below: find . -name "*-expected.txt" | grep -v baselines | grep -v flag-specific | xargs -I{} cp --parent {} platform/generic find . -name "*-expected.txt" | grep -v baselines | grep -v flag-specific | xargs rm -f Repeat the command for *-expected.png and *-expected.wav. commit the change. Step 3: Some tests hard coded path to the baselines they will use. Move such baselines back to its original folder and commit the change. See fast/events/nested-event-remove-node-crash.html and webaudio/resources/oscillator-testing.js etc. Bug: 1299834 Change-Id: I8d9dd3c6e34b9c814ba615c8a58ccc9d4ad64ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3603221 Reviewed-by: Stephen Chenney <schenney@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Weizhong Xia <weizhong@google.com> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/main@{#998729}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.