commit | 70016448e6ab82000097bd4c7bbf15925894e555 | [log] [tgz] |
---|---|---|
author | Dominic Battre <battre@chromium.org> | Mon Oct 17 12:50:06 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Oct 17 12:50:06 2022 |
tree | 87a187442ff47a6b948fd07e885160b368992515 | |
parent | 9a0735949dadbb33ee3653330be0745b9aab03dd [diff] |
Move lists of test files to autofill directory FormStructureBrowserTests on iOS differ from other platforms in that they need a full list of testfiles listed in the BUILD.gn file. On other plotforms, you just dump a new file into the directory and everything works. This has bugged me several times. 1) I typically add the files and later learn that iOS tests fail. 2) I need to find the right BUILD.gn file to add the new entry. 3) I need one more OWNERS approval. Given that adding a file does not require any specific iOS expertise I propose to move the list of test files closer to where the files actually live and move them under the OWNERS purview of the autofill team. Fixed: 1374902 Change-Id: I068a119bf9c876dbbaac4869876c9a129d50231e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3956739 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1059903}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.