commit | 705e9082e97f3ad583223a17a09a0fb865238851 | [log] [tgz] |
---|---|---|
author | Sunggook Chue <sunggch@microsoft.com> | Fri Mar 29 01:19:02 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Mar 29 01:19:02 2024 |
tree | ab1084802fed5d0d9ef68011b484bc9e614c4182 | |
parent | 291be0c864aeae6202a1b525eef00ed4ee2abfa1 [diff] |
Fix Check for AAC on Windows N In the context of Windows N SKU, the isTypeSupported function does not include support for AAC (Advanced Audio Coding) encoding. In standard Windows operating systems, AAC encoding relies on the Media Foundation library. However, this library is not installed by default in Windows N SKU, resulting in the lack of AAC encoding support. The straightforward solution is to check whether the system is running Windows N SKU and return false for AAC support. An alternative approach involves examining the presence of the Media Foundation binaries (such as mf.dll). Unfortunately, this file existence check cannot be performed directly in the renderer process. The GPU process already handles this check, but the isTypeSupported API operates synchronously and cannot utilize a Mojo-based solution. It’s worth noting that Windows N SKU is optional for European countries and Korea, although it is not widely used. Therefore, a simple check based on the product type could be a more effective solution. Bug: 329698355 Change-Id: I00e946895d18377e87c6b8c57539184722c086f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5379757 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sunggook Chue <sunggch@microsoft.com> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/main@{#1280027}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.