Google Git
Sign in
chromium / chromium / src / 706ee6daa65a6d1b38af7864b5b136893fb3a348
commit706ee6daa65a6d1b38af7864b5b136893fb3a348[log] [tgz]
authorReilly Grant <reillyg@chromium.org>Thu Apr 18 22:53:08 2019
committerCommit Bot <commit-bot@chromium.org>Thu Apr 18 22:53:08 2019
tree0b3a17888da42a8fd1835052c61a65330c207965
parent7318c3d0bb4812240c2b71e9413f967900fce9c5 [diff]
Notify of UsbService destruction as 1st step in destructor

This change ensures that observers are notified that the UsbService is
being destroyed as the very first step of the destructor, which
unfortunately means that an explicit call needs to be added as the first
line of every subclass destructor.

This allows the DeviceManagerImpl instance in the device service to
close all bindings before callbacks owned by the UsbService are
destroyed. Otherwise these trigger a DCHECK.

Bug: 953248
Change-Id: I0a05f29a6e759cb4340301b92f13ea90af76bcd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574142
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652373}
10 files changed
tree: 0b3a17888da42a8fd1835052c61a65330c207965
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .