Add UseCounters for <dialog> + CloseWatcher changes If we are to ship the current integration of CloseWatcher with <dialog>, we will be: * Sometimes closing multiple dialogs, when a close signal comes in and multiple <dialog>s have been created without user activation. * Sometimes not firing the cancel event, if the <dialog> was created, never interacted with, and then closed via a close signal. Both of these are technically backward-incompatible changes. However, they should only occur when a website is doing something relatively unusual. So, this change adds UseCounters to see how often these cases occur, so we know whether to push for shipping this, or reconsider our strategy. This patch was started here: https://chromium-review.googlesource.com/c/chromium/src/+/3711968 Fixed: 1383001 Change-Id: Ic0f5cd6d2ea5bcb06d1711f51327749386f88e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4084041 Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Joey Arhar <jarhar@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#1081076}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.