Attach the DataSharingTabHelper when versioning requires it Even though shared tab groups might be disabled, we still want to intercept some URLs when the app is out-of-date, to show a static page when the feature is disabled by versioning, but no special UI is allowed to show it. Instead, we open a static page. For reference, this is equivalent to https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/data_sharing/data_sharing_navigation_throttle.cc;l=57-58;drc=34f0d2690d43df1880f2cf7c265cf27d1c86e0a7 for the other platforms. Tested: I tried to join a group from a link with the following flags: - data-sharing: ON - versioning: out-of-date, no UI. It correctly opened the static page. Fixed: 428754508 Change-Id: I8b6f15bc9e5f244c3e62e1eece4d66b963b09563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6692532 Auto-Submit: Louis Romero <lpromero@google.com> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Louis Romero <lpromero@google.com> Cr-Commit-Position: refs/heads/main@{#1480943}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.