commit | 70fdf149b21a80c12fe2ce669b5774af1dc550b6 | [log] [tgz] |
---|---|---|
author | Michael Lippautz <mlippautz@chromium.org> | Mon Jan 07 19:07:24 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jan 07 19:07:24 2019 |
tree | 0cdeb5fd7832a76a3c6ad0f0f90d7c89ecf7f661 | |
parent | b919b3c6065c47953cf9d0f66f0689dcb7799db8 [diff] |
bindings: Convert DOMObjectHolder user to CustomWrappableAdapter This is *not* a correctness fix but merely a refactoring to a different approach. Both, DOMObjectHolder and CustomWrappableAdapter, serve the same purpose: They keep alive a DOM object from a JS object. Since CustomWrappableAdapter is already used for JS callbacks it fits well and replaces one use of custom weak callbacks. On top of that, CustomWrappableAdapter creates a V8 Persistent instead of a "temporary" Oilpan root in a hashmap. On master there's no real difference as both are root sets for Oilpan visitation. Unified heap does not need to visit V8 persistents as roots, so it's cheaper in the new world. Change-Id: I12ddde7e6ec1a21204826c8c4d35acea24965e0f Bug: 843903 Reviewed-on: https://chromium-review.googlesource.com/c/1396023 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#620409}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .