Google Git
Sign in
chromium / chromium / src / 71104fd3
commit71104fd37d95412b1ca53ae601a0775e900e11c0[log] [tgz]
authorKhushal <khushalsagar@chromium.org>Wed Feb 27 04:39:34 2019
committerCommit Bot <commit-bot@chromium.org>Wed Feb 27 04:39:34 2019
treee4d77dbfd4fdbb8b040e1b1fa847a84e2d327cd8
parent80f73e86fb9ed9ba2a43753bcf9fb67a9ce859f1 [diff]
gpu: Fix partial damage update synchronization in BufferQueue.

BufferQueue maintains tracking for damage in previous frames, and copies
it to the buffer for the current frame for partial swap. But because
the copy happens after generating the ready fence for the
OutputSurface's overlay, this creates a synchronization bug where the
display controller could try to read from this overlay while the GPU is
still writing to it.

Avoid this by notifying the OutputSurface of the damage for the current
frame before the ready fence is generated.

R=piman@chromium.org

Bug: 889530
Change-Id: Ic9e099c0bea7b8c990d1485d581590ee3ce81b77
Reviewed-on: https://chromium-review.googlesource.com/c/1487884
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635873}
14 files changed
tree: e4d77dbfd4fdbb8b040e1b1fa847a84e2d327cd8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .