Google Git
Sign in
chromium / chromium / src / 717e786d0b1f416b41b296fc863d1e6180759f7e
commit717e786d0b1f416b41b296fc863d1e6180759f7e[log] [tgz]
authorFederico Paredes <fedpar@microsoft.com>Wed Aug 18 01:27:20 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Aug 18 01:27:20 2021
treedf0199ab8ae6398fb56b27f8f6a17d3297243a6d
parent1a1296891c72609e653e437cfbc2643bae90bb8a [diff]
Fixed crash when adding all bookmarks to new group

The browser would crash when activating the "Open all in new tab group"
menu item while on an empty Bookmarks bar (or empty folder). This change
does 3 things:
1. Add a simple DCHECK in TabStripModel::AddToNewGroup to verify that
   the indices parameter isn't empty.
2. Gray out the "Open all in new tab group" option if there are no
   bookmarks.
3. Add a DCHECK if the user somehow selects "Open all in new tab group"
   and there are no bookmarks, just in case the option were to ever show
   up as enabled when it shouldn't.

Bug: 1240694
Change-Id: I4eb8bd47e7b4aa1f9335282d8cd6210946361d17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3100552
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Charlene Yan <cyan@chromium.org>
Commit-Queue: Federico Paredes <fedpar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#912845}
2 files changed
tree: df0199ab8ae6398fb56b27f8f6a17d3297243a6d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.