Google Git
Sign in
chromium / chromium / src / 71d0b8e79eaf503a3f34fabdb5ec3a59cae40488
commit71d0b8e79eaf503a3f34fabdb5ec3a59cae40488[log] [tgz]
authorMing-Ying Chung <mych@chromium.org>Mon Mar 04 06:27:28 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Mar 04 06:27:28 2024
treef932136ee34023ed336e108c91926daad4d26832
parentd6157123a124790e91400051c421968584fe10f7 [diff]
Force evicting subframe in NavigationRequest::OnStartChecksComplete()

In the case when a main frame and its subframe both starts navigations
around the same time, if the main frame commits the navigation earlier
than its subframe, the subframe may be incorrectly put into BFCache
along with the main frame before reaching this method, causing errors
like [1] after https://crrev.com/c/5308025 is submitted.

This CL forces evicting subframe in such case.

[1]: https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1688922/overview

Bug: 41483740
Change-Id: Iccc0c81a358447fdbf50cf687ffa375b4e5fdd9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5316738
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Auto-Submit: Ming-Ying Chung <mych@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1267702}
3 files changed
tree: f932136ee34023ed336e108c91926daad4d26832
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.