commit | 71d7dcfc56b27c356521cb418dc7d6bc468a577f | [log] [tgz] |
---|---|---|
author | Pranav Modi <pranavmodi@microsoft.com> | Tue Feb 25 09:29:44 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Feb 25 09:29:44 2025 |
tree | a611eea36a4a6e5c6dce04b2b21caf8d6d40e3bf | |
parent | f0a9b7873e91115b0f568bfdd8130256524f767f [diff] |
[WPT] Fix WPTs failing on chrome Following WPTs were failing on chrome and passing on content_shell and headless_shell. third_party\blink\web_tests\external\wpt\editing\other\ merge-span-with-style-after-backspace-having-contenteditable.html third_party\blink\web_tests\external\wpt\editing\other\ merge-span-with-style-after-forwarddelete-having-contenteditable.html third_party\blink\web_tests\external\wpt\editing\other\ merge-span-with-style-after-pressing-enter-followed-by- backspace-in-contenteditable-div.html These WPTs were failing in chrome but passing in content_shell and headless_shell. The WPTs were failing because it was using editor-test utils where we are placing the caret at time of setting up editing host. Somehow the caret placed moves to the end of the text node when we call the backspace key in chrome but works fine in content_shell and headless_shell. This leads to deletion of the last character in the textnode instead of the desired output. Hence, I have modified the test to use selection and range to place the caret which works fine in all shells. Bug: 398413722 Change-Id: Iff6f8438c6982084601d846cac496000e1edf912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6295383 Commit-Queue: Pranav Modi <pranavmodi@microsoft.com> Reviewed-by: Sanket Joshi <sajos@microsoft.com> Reviewed-by: Sambamurthy Bandaru <sambamurthy.bandaru@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1424384}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.