Reland "Reland "Integrate CookieControlsPageActionController with the browser"" This is a reland of commit c75e239ad273212a23dee98c61573f089dea92be Confirmed this CL passes on the previously failing trybot: https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_chromeos_msan_rel_ng/8091? See diff from patchset 1 for changes. The original CL was reverted because the bubble controller was trying to remove its observation of the CookieControlsController during shutdown, but CookieControlsController was already destroyed. This CL fixes this by explicitly closing the bubble when the tab is deactivated OR detached. Original change's description: > Reland "Integrate CookieControlsPageActionController with the browser" > > This is a reland of commit 13a9813ebf42e70fb00b107e7daa7e8d727923d2 > > See diff from patchset 1 for changes. The original CL was reverted > because the bubble controller was trying to remove its observation of > the CookieControlsController during shutdown, but > CookieControlsController was already destroyed. This CL fixes this by > explicitly closing the bubble when the tab is deactivated. > > Original change's description: > > Integrate CookieControlsPageActionController with the browser > > > > CookieControlsPageActionController, which manages the migrated cookie > > controls page action path, is hooked up to the rest of the browser, > > allowing it to take effect. This change consists of: > > - Defining the browser action to trigger the page action > > - Initializing the controller in TabFeatures > > - Updating tests to use the new browser action to simulate invoking the page action > > - Enabling the migration flag in fieldtrial_testing_config.json and adding it to the about://flags option. > > > > Bug: 376283777 > > Change-Id: I4250c1c2d2193cbd02050a1591725a45d660ee6e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6956907 > > Commit-Queue: Kaan Alsan <alsan@chromium.org> > > Reviewed-by: Dana Fried <dfried@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1526323} > > Bug: 376283777 > Change-Id: Ia534aa62902e850ee4c1384f22af7261522b55ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7021969 > Reviewed-by: Dana Fried <dfried@chromium.org> > Commit-Queue: Kaan Alsan <alsan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1527679} Bug: 376283777 Change-Id: Ibec939cfe2eea668ed99cd37daa66809515ee9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7030544 Reviewed-by: Dana Fried <dfried@chromium.org> Commit-Queue: Kaan Alsan <alsan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1529665}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.