Google Git
Sign in
chromium / chromium / src / 721bbe5a4da69f86c172fb9100220f5f7340bac0
commit721bbe5a4da69f86c172fb9100220f5f7340bac0[log] [tgz]
authorJoey Arhar <jarhar@chromium.org>Tue Jan 28 18:15:04 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 28 18:15:04 2025
tree799c2131cf7ea961b8155e3848e47eea36bca44a
parent15b834b797566c71c37ae563de7515ba63a8e220 [diff]
Reapply "Fix OptionList iterating before beginning"

The new test in the original patch was failing on a Linux UBSan bot,
which revealed that OptionListIterator::operator*() was dereferencing a
null element. I fixed this by adjusting the test and adding a DCHECK to
make sure the element is not null before dereferencing. I also added a
WPT to make sure that the DCHECK doesn't get hit.

This reverts commit 3bef4696dcb69725d3f1c72a0984ba91c2e00056.
Original patch: commit 505729eedfd6243a6520d9fd09012b5dde449511

Fixed: 388299752
Change-Id: I01712fec0479ca567121051b33e6478cf77818b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6203424
Commit-Queue: Traian Captan <tcaptan@chromium.org>
Auto-Submit: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Traian Captan <tcaptan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1412393}
5 files changed
tree: 799c2131cf7ea961b8155e3848e47eea36bca44a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. description
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.