commit 7221d5411e0628408e4dc90cc53183dba8d5a634
author Lijin Shen <lazzzis@google.com> Fri Jul 19 22:35:43 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 19 22:35:43 2024
tree 213e4304a5329a6471bcc7caa9c7f79e7b863332
parent 0d9f83b4ff8625acef267d475e80cd19a6c8bfbd

Re-Reland "[Default Nav Transition] Remove top controls in NTP screenshot""

This reverts commit 918efe49d3678b781f07f87d0b018ad64f1ba84c.

Reason for revert: Skia gold is not triaged in some bots

Original change's description:
> Revert "Reland "[Default Nav Transition] Remove top controls in NTP screenshot""
>
> This reverts commit 26c52b7ed0624dbd41df02cd719ed2b50c7c58c2.
>
> Reason for revert: Test added is consistently failing. See details
> in https://b.corp.google.com/issues/331814846#comment18.
>
> Original change's description:
> > Reland "[Default Nav Transition] Remove top controls in NTP screenshot"
> >
> > This reverts commit c2fd4d5853f233dc111d15b5f7ced9134b0641bd.
> >
> > The tests are using NavigationHandler which only
> > works in 3-button nav mode and the test failed on OS
> > which defaults to gesture nav mode.
> >
> > Original change's description:
> > > Revert "[Default Nav Transition] Remove top controls in NTP screenshot"
> > >
> > > This reverts commit 7938c61cf27787612c36688e9ebe841c2050f1a8.
> > >
> > > Reason for revert: Causing bots to fail on CI: https://crbug.com/351979006
> > >
> > > Original change's description:
> > > > [Default Nav Transition] Remove top controls in NTP screenshot
> > > >
> > > > In order to match the viewport of the webpage screenshot, this CL
> > > > excludes the area of top controls of NTP and maintain the
> > > > size of the screenshot. As a result, the bottom part of the screenshot
> > > > will be filled with the default background color of the NTP because
> > > > it is impossible to draw off-screen views in Android.
> > > >
> > > > Screenshot (with top controls): https://screenshot.googleplex.com/AJFcDYvXCbnvXgj.png
> > > > Screen record (w/o top controls): http://screencast/cast/NDY4NTA0OTc2ODE4MTc2MHxjODkyNWE0Zi1jOQ
> > > >
> > > > Bug: 331814846
> > > > Change-Id: Ieb8959ad2f202b15e055346f889a73355cdc4e06
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5560151
> > > > Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
> > > > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> > > > Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
> > > > Commit-Queue: Lijin Shen <lazzzis@google.com>
> > > > Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
> > > > Cr-Commit-Position: refs/heads/main@{#1324606}
> > >
> > > Bug: 331814846
> > > Change-Id: Idee7cef1905d173ae74233fb5aa566e58f070691
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5687334
> > > Owners-Override: Rupert Wiser <bewise@chromium.org>
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Commit-Queue: Rupert Wiser <bewise@chromium.org>
> > > Cr-Commit-Position: refs/heads/main@{#1324742}
> >
> > Bug: 331814846, 351979006
> > Change-Id: Iac27e3d8cba61a2312d457bedcb61d16048ae5f4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689652
> > Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
> > Reviewed-by: Rupert Wiser <bewise@chromium.org>
> > Commit-Queue: Lijin Shen <lazzzis@google.com>
> > Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
> > Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1326304}
>
> Bug: 331814846, 351979006
> Change-Id: I16afc5760780350eb4d22635cc1814807d5bee2d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5697875
> Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Yue Zhang <yuezhanggg@chromium.org>
> Owners-Override: Yue Zhang <yuezhanggg@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1326454}

Bug: 331814846, 351979006
Change-Id: I7ff2b16ba98d5fef691c0ab367989010df6ec3ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5699245
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/main@{#1330554}