commit | 7223a2c09fef80576d8e0bb88e40864303ce474e | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <kubo@igalia.com> | Fri Jan 17 00:43:01 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 17 00:43:01 2025 |
tree | 0594c14def15560915c02f193176390314f47ead | |
parent | 6f158a09d7859c43771292a30857022e01f1eb50 [diff] |
[ios] Use UIStackView to simplify web_view_shell layout code By making |headerBackgroundView| and |headerContentView| UIStackView instances, we can let UIStackView figure out a lot of the constraints on its own and simplify the code significantly: * |headerBackgroundView| is a 1-item UIStackView that just contains |headerContentView|. It inherits the root view's margins so that |headerContentView| is laid out respecting the safe area and the layout guide margins. * |headerContentView| is a horizontal UIStackView containing the navigation buttons and the location bar. The items are vertically centralized and fill the UIStackView horizontally according to the content hugging settings (i.e. the location bar expands horizontally, the buttons do not). By comparing screenshots of before and after with //tools/image_diff, the only difference is a small change to the location bar in height, as it no longer has a hardcoded size of 32 points. Change-Id: I9f27dd1e4e60b59b2ac1844c0ae965dad17f9fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6176975 Auto-Submit: Raphael Kubo da Costa <kubo@igalia.com> Reviewed-by: John Wu <jzw@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/main@{#1407650}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.