Google Git
Sign in
chromium / chromium / src / 727fb0ec138d2c26bdfa495d503ffcd55dff13af
commit727fb0ec138d2c26bdfa495d503ffcd55dff13af[log] [tgz]
authorPeter Wen <wnwen@chromium.org>Thu Sep 04 15:56:11 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Sep 04 15:56:11 2025
tree0b9d1b28d45390ba7f6c81c636b7fee52e168b59
parent49d16993592987c10ab53f183a49f1fe00639cc0 [diff]
android: Fix direct deps suggestions for R.java

R.java is a generated class that is not found in the .sources file for
its target but rather is directly generated into the target's
__assetres.srcjar zip file. This means that ClassLookupIndex is unable
to find it as a ClassEntry.

jdeps is able to find it as the R.class file is present in the target's
.turbine.jar file.

Thus rather than trying to fix this corner case, rely on jdeps for these
class that are missing from the ClassLookupIndex but has a potential
target found by jdeps. This is a more general fallback approach than
finding a way to add R.java to the ClassLookupIndex graph as a special
case.

R=agrieve@chromium.org

Bug: 437121440
Change-Id: I1e9c6656da160198a6f7b5387522ab052ad8bd28
Fixed: 437121440
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6916814
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1510945}
1 file changed
tree: 0b9d1b28d45390ba7f6c81c636b7fee52e168b59
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. clusterfuzz-data
  52. internal
  53. ios_internal
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .cursorignore
  60. .geminiignore
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. SECURITY_OWNERS
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.