Google Git
Sign in
chromium / chromium / src / 72acd7e4260c6415c2dbc035050c1c0a4e971494
commit72acd7e4260c6415c2dbc035050c1c0a4e971494[log] [tgz]
authorClemens Arbesser <arbesser@google.com>Fri Feb 19 11:42:42 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Feb 19 11:42:42 2021
treecf2d2047e675b2788142ac0fca6d3e9c2058a308
parentc69f999e3c16899caf6705d21ef6c262ee234846 [diff]
[Autofill Assistant] Move hard-coded parameters into ScriptParameters.

This is a follow-up CL to http://crrev/c/2691213.
- Move all hard-coded parameters into ScriptParameters.
- Make it illegal to call GetParameter() to gain access to arbitrary
parameters. Instead, there are now dedicated getters for every client-
relevant parameter. The internal representation and the names of
parameter keys is now abstracted from the interface.
- Introduce typed script parameters (for now, only string and bool).
For now, the internal representation is still based on strings, but
the intention is to eventually send typed information from the intent
extras directly to native (rather than the current stringified
parameters).

This CL also moves the matching of script parameter values into
ScriptParameters. It is a good fit, and it allows removing code
duplication between ScriptPrecondition and StaticTriggerCondition.

Finally, this CL removes legacy treatment for vertical-specific details
parameters. They have been replaced with generic parameters a long time
ago, so this should be safe to do.

Bug: b/179648654
Change-Id: I0bd48bec369ff1dfd8550a6001c9d46048767b16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2696425
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Luca Hunkeler <hluca@google.com>
Cr-Commit-Position: refs/heads/master@{#855674}
11 files changed
tree: cf2d2047e675b2788142ac0fca6d3e9c2058a308
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.