commit | 72d4b84d50920915ce19b2e8c738a9e7493a817a | [log] [tgz] |
---|---|---|
author | Nate Chapin <japhet@chromium.org> | Wed Oct 30 22:02:36 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Oct 30 22:02:36 2024 |
tree | bb0aa9aabb441349a7c76c5526b17995f54a7edb | |
parent | 8f11ef8c4adbe4af517fe05aec0c75a34a0ba47d [diff] |
Revert "ozone/wayland: Attach null buffer when hiding toplevel window" This reverts commit c5372ced02388f538ad7bb34b97d49af113c2037. Reason for revert: Linux MSAN failure: https://luci-milo.appspot.com/ui/inv/build-8732641056961992049/test-results?q=XdgVersionStableTest%2FWaylandWindowTest.ReattachesBackgroundOnShow%2F0&sortby=&groupby= Original change's description: > ozone/wayland: Attach null buffer when hiding toplevel window > > There's a bug in Weston that makes Chromium unable to receive mouse > input after hiding a window and making it visible again for fallback tab > dragging (https://gitlab.freedesktop.org/wayland/weston/-/issues/950). > > We can fix this by attaching a null buffer to the underlying wl_surface > when hiding the toplevel window. > > To ensure we don't call back to DWTHPlatform when hiding the window > directly before closing it, as `native_widget_delegate_` might have been > destroyed already, we call PrepareForShutdown() in DWTHPlatform::Close() > already. > > Fixed: 360700861, 368982572 > Change-Id: Ia5c9edbacedd03857e39b7bc1edd2c02313cb52e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5854165 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Commit-Queue: Max Ihlenfeldt <max@igalia.com> > Cr-Commit-Position: refs/heads/main@{#1375841} Change-Id: I0ad6bc7e357c589f280b664dced8049b64cb1016 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5980870 Commit-Queue: Nate Chapin <japhet@chromium.org> Owners-Override: Nate Chapin <japhet@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1375943}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.