Google Git
Sign in
chromium / chromium / src / 55c9c2ae93d7119e763315b7e355668fb34d373e
commit55c9c2ae93d7119e763315b7e355668fb34d373e[log] [tgz]
authorXida Chen <xidachen@chromium.org>Tue Mar 24 15:36:42 2020
committerCommit Bot <commit-bot@chromium.org>Tue Mar 24 15:36:42 2020
tree1df31f8e507eae7827918919f945843adba123b4
parentdb608379e1a9de9b2c4c9fef78868429c06e19ea [diff]
Add a null check in CheckCanStartEffectOnCompositor

The related code was changed in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1698667.

The crash reported in this bug was caused by missing a null check
in the above CL. This CL adds the null check.

Bug: 1063652
Change-Id: I9ec52b320090d36b523b6fe2eac5e363a8f76005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114583
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752855}
3 files changed
tree: 1df31f8e507eae7827918919f945843adba123b4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.