commit 731c2d041115aa12861bad35657a0bcacac39f83
author Akihiro Ota <akihiroota@chromium.org> Wed Apr 06 18:33:49 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Apr 06 18:33:49 2022
tree d485176d5c36def572fae8b88a551bb4cc6b6364
parent d61d3875ead9ab1a25effdde81feabb0b86bf553

SpeechRecognitionPrivate: Prevent dangling callbacks

This change addresses a crash that occurs when rapidly starting and
stopping speech recognition. The root of the crash is that we assume
that the call to start() will always succeed (though it might take some
time), and thus its callback will always be run. However, when rapidly
starting and stopping speech recognition over and over again, we
sometimes stop speech recognition before it can be started. This leads
to issues where the callback to start() never responds and causes a
crash here [1].

This fix ensures that `on_start_callback_` is run with an error if
speech recognition is prematurely stopped.

[1] https://source.chromium.org/chromium/chromium/src/+/main:extensions/browser/extension_function.cc;l=453?q=extension_function.cc&ss=chromium%2Fchromium%2Fsrc

over again

AX-Relnotes: Fixes a crash when toggling Dictation rapidly over and
Bug: 1311847
Change-Id: I2f4807aabfa9d95f0b60f7c767c2af17222bf53e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3564691
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/main@{#989535}