Google Git
Sign in
chromium / chromium / src / 732563faff4598f0bc6b802e819aae0931fa84f4
commit732563faff4598f0bc6b802e819aae0931fa84f4[log] [tgz]
authorStepan Khapugin <stkhapugin@chromium.org>Tue May 31 13:54:34 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 31 13:54:34 2022
treee456e021e8a8dd36c4a48dde32f64c456e85358e
parent4e4edfacaba8405705a2cac7fee35ac534d9352c [diff]
[iOS][Omnibox] Fix RTL bug in treatment 1 new popup

This cherry-pick has a merge conflict because this refactoring CL:
https://chromium-review.googlesource.com/c/chromium/src/+/3645048
is not present on the branch. Manually resolved.

Original CL description:

Fix RTL behavior in the new popup:
1. Use the existing setSemanticContentAttribute method to get omnibox's
text direction, and push it down as layoutDirection @Environment var
2. Update the layout-guide-to-swiftui-offset calculation to take RTL
into account
3. Stop aligning images by center, align by left edge instead. It's less
future-proof but makes code a bit more readable
4. Minor changes: previews configuration and debug description added
to PopupUIConfiguration


(cherry picked from commit 43d9d4dda8efb293143656aaa8b39b1b40180549)

Fixed: 1327329
Change-Id: If00bc82b228b4c4056017bea6bc641000e619fa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3657317
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1007341}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3679078
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#406}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
5 files changed
tree: e456e021e8a8dd36c4a48dde32f64c456e85358e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.