Google Git
Sign in
chromium / chromium / src / 733b05c67da81b70c0cdcb1538bbce1e1afe8681
commit733b05c67da81b70c0cdcb1538bbce1e1afe8681[log] [tgz]
authorVeronique Nguyen <veronguyen@google.com>Thu Jun 29 20:07:05 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jun 29 20:07:05 2023
treee52e88c05d60e04048159b0f1422c7eca4334eb0
parenteb016bb1409b7829b3d43ce5122e30c0d98b1639 [diff]
Revert "[IOSPasswordBottomSheet] Change action button string"

This reverts commit 4b8d812c90727e17a8e22b19ba3908eb61701e4f.

Reason for revert: Issue with the behavior of the keyboard for XCode 14.2 (only works in 14.3 and up) so we have to revert this and land this in M118

Original change's description:
> [IOSPasswordBottomSheet] Change action button string
>
> - Use "Use Keyboard" instead of "No Thanks" for the bottom sheet
> dismiss action button.
> - Update EG test that uses the string.
>
> Bug: 1457186
> Change-Id: I25f9dbf3f2aa190b9ab9a71b504d7c6a0d096986
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4636981
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Commit-Queue: Veronique Nguyen <veronguyen@google.com>
> Cr-Commit-Position: refs/heads/main@{#1161237}

Bug: 1457186
Change-Id: I25a2539ab6dbf18c1b462d8822b6fbc6864c4efc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4649914
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Veronique Nguyen <veronguyen@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1164302}
6 files changed
tree: e52e88c05d60e04048159b0f1422c7eca4334eb0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.