| commit | 7364a248f0b4dc4968e77cfedd5c27ab1e1aa2e4 | [log] [tgz] |
|---|---|---|
| author | Bo Liu <boliu@chromium.org> | Wed Sep 16 20:29:53 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Sep 16 20:29:53 2020 |
| tree | a39005afbd8643a929c7c8e1601fc0095db2cc73 | |
| parent | e1eca8d7035b30ffe10a116109f8aaf64d211629 [diff] |
weblayer: Fix visibility change on config change If fragment is stopped due to config change, then there is no need check whether views are attached for visibility since we want to maintain that the active tab is visible in that case. And remove the call to destroy attachment in detach, which is not needed anymore to maintain visibility. And it's probably the source of some crashes caused by destroying attachment too early before all views are detached and the activity destroyed. Bug: 1127246 Change-Id: I863ae612d1015dee433fbabd16dc7c81d82e60c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414668 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#807642}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.