Google Git
Sign in
chromium / chromium / src / 739d3fc4830cf25624ba619d0612b4404253c861
commit739d3fc4830cf25624ba619d0612b4404253c861[log] [tgz]
authorMuyao Xu <muyaoxu@google.com>Wed Sep 04 02:38:34 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Sep 04 02:38:34 2024
treeae42886287131609b455495e398e8291e05656a4
parent616eb986e6aee631c58f2b0900877064917db6a9 [diff]
[M129] Close the Media Router device picker dialog on page closed

The code to close the dialog on page destruction exists, but it failed
to close the dialog because MediaRouteChooserDialogManager inaccurately
shows the dialog has been closed, causing an early return in
BrowserMediaRouterDialogController::closeDialog().

This CL changes the controller to always close the dialog regardless of
whether the dialog is showing or not.

(cherry picked from commit e51a64c9af60bddb50141a835ac32e061e81d25f)

Bug: 361784548
Change-Id: If94fa9fb60c9e691564a04630730dab4dbd2bf01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5819835
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Commit-Queue: Muyao Xu <muyaoxu@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1348098}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5834036
Commit-Queue: Ahmed Moussa <ahmedmoussa@google.com>
Reviewed-by: Ahmed Moussa <ahmedmoussa@google.com>
Auto-Submit: Muyao Xu <muyaoxu@google.com>
Cr-Commit-Position: refs/branch-heads/6668@{#823}
Cr-Branched-From: 05bc664984ca075216b7f2198c88b9725bfa1b9b-refs/heads/main@{#1343869}
1 file changed
tree: ae42886287131609b455495e398e8291e05656a4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.