PRESUBMIT.py: Revisit default handling of BanRule::treat_as_error

The docs state [1] the default value of None is equivalent to True.
BanRules are used in 2 checks:
* _CheckAndroidNoBannedImports(): Here the docs *happen* to be correct,
  because all current rules leave the field unspecified [2] and the
  function issues errors unconditionally without ever reading the
  field [3].
* CheckNoBannedFunctions(): Here the docs are incorrect, None is treated
  like False [4].

Given that, change the following:
* Get rid of the None nonsense, we can just specify a default boolean
  value directly. Do this in such a way that, after this CL, warnings
  remain warnings and errors remain errors.
* Merge _CheckAndroidNoBannedImports() into CheckNoBannedFunctions(),
  modulo renaming the function and tweaking output strings. The
  duplication was the underlying root cause for the discrepancy and
  there was already a TODO about merging them.
  One consequence is the imports are checked on both commit and upload
  now (before the CL, _CheckAndroidNoBannedImports() was called by
  ChecksAndroidSpecificOnUpload(), which only triggered on upload).
  Another consequence is that now it's possible to add banned imports
  that issue presubmit warnings and not errors.

[1] https://source.chromium.org/chromium/chromium/src/+/main:PRESUBMIT.py;l=130;drc=9100968543997df5923fa4918179b6be1b7c6a3a
[2] https://source.chromium.org/chromium/chromium/src/+/main:PRESUBMIT.py;l=140-170;drc=9100968543997df5923fa4918179b6be1b7c6a3a
[3] https://source.chromium.org/chromium/chromium/src/+/main:PRESUBMIT.py;l=3033;drc=9100968543997df5923fa4918179b6be1b7c6a3a
[4] https://source.chromium.org/chromium/chromium/src/+/main:PRESUBMIT.py;l=2937;drc=9100968543997df5923fa4918179b6be1b7c6a3a

Change-Id: I1cba6be74b5ab11f5924660073664fd4c123979b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7006085
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/main@{#1524551}
2 files changed
tree: da392a83be604d1bf5090b38ef3af36e88534620
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .geminiignore
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. SECURITY_OWNERS
  82. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.