Google Git
Sign in
chromium / chromium / src / 73dba7e1b6b8c7f61556f7968ca02aecfedfaa10
commit73dba7e1b6b8c7f61556f7968ca02aecfedfaa10[log] [tgz]
authorKent Tamura <tkent@chromium.org>Tue Oct 03 06:07:17 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Oct 03 06:07:17 2023
tree21452053b7c03f9644434f815bf82cdde41c78d9
parentdd5789dd8b25a2066c76a34bd57e2516c5078f50 [diff]
[RemoveLegacy] Represent VisualOverflow by PhysicalRect, not LayoutRect

Now VisualOverflow boxes are in the physical coordinate system, instead
of the flipped block-flow physical coordinate system. This CL replaces
LayoutRect usages for VisualOverflow with PhysicalRect.

* All LayoutRect usages in BoxVisualOverflowModel are replaced with
  PhysicalRect

* VisualOverflowRect(), SelfVisualOverflowRect(), and
  ContentsVisualOverflowRect() return PhysicalRect. Their
  'Physical' variants are removed.

* VisualOverflowRectForPropagation() is removed. We don't need to flip
  VisualOverflow boxes any longer.

This CL should have no behavior changes.

Bug: 1229581
Change-Id: Id231b65cb3f80e3b60715efec164149eb1edec00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4904260
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204482}
34 files changed
tree: 21452053b7c03f9644434f815bf82cdde41c78d9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.