commit 2265de70455f330d4463e0b559152dc98c93c551
author Jordy Greenblatt <jordynass@chromium.org> Thu Jul 26 19:05:26 2018
committer Commit Bot <commit-bot@chromium.org> Thu Jul 26 19:05:26 2018
tree 9bedd844221b3c5e1d4e92918e0a9ed683664ebd
parent 38ca7b11c3df03e49e29d49375492b32c30040b0

[CrOS MultiDevice] Register suite pref and surface in setting

This CL implements the skeleton of the prefs controlling MultiDevice
features as laid out in khorimoto's mini design doc
https://docs.google.com/document/d/1XvTd1kuU7ZigOFwau39oDstg_-wjjjGD3Lf02Cc9Oek/edit#

Note that the MultiDeviceSetupService::RegisterProfilePrefs() call
in profile_impl.cc needs to be moved outside the flag progected if
block where it currently is because it will eventually include the
registration of some prefs that are not not controlled by the same
flags (e.g. Instant Tethering).

Note that I also deleted the old kSmsConnectEnabled pref to avoid
confusion. It was added according to a now deprecated design and is
not used anywhere so this will have no effect. It will soon be moved
to chromeos/services/multidevice_setup/public/cpp/prefs and, once
the SMS Connect Item is added to the MultiDevice Settings UI subpage,
added back in. However, in order to have the prefs in settings
reflect the state of the MultiDevice Settings UI, I don't want it
in Settings UI (especially not whitelisted from a misleading
file and namespace).


-------------

To test it I surfaced the pref in the settings pref singleton and
verified that it appears as expected. Here is a screenshot from the
settings page console on my dev PixelBook:

https://drive.google.com/open?id=0B1-cJJPK-cu6dS10ZGRId3U3Sm56a3JaZ04tbWdDTGt2aTE0

Bug: 824568
Change-Id: I3537e19b81e8c3db9bc7cc6f6fedf7780465ea22
Reviewed-on: https://chromium-review.googlesource.com/1149194
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578391}