Google Git
Sign in
chromium / chromium / src / 73f6bd2d9c91d78e0435c846427b7b49515c67ed
commit73f6bd2d9c91d78e0435c846427b7b49515c67ed[log] [tgz]
authorZoraiz Naeem <zoraiznaeem@chromium.org>Tue May 13 17:56:52 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 13 17:56:52 2025
tree047939c2f6fd1facd9db6bee08ad5f6f52cf8da2
parente3887de2915bcb878acd6ebbfc8346fbe906d1f4 [diff]
Correctly configure transparent TrayBubbleView

Background: A transparent TrayBubbleView is used as a container for
hosting content.

Reasons for the change: To ensure a transparent tray bubble after the
changes in crrev.com/c/6501740, the bubble background color must be
explicitly set to transparent. This is because that change will cause
the client view to always be painted to a layer. Currently, this is not
a problem as TrayBubbleView does not paint its client view to a layer,
so a background on the client view is not painted. Setting the
background to transparent is a prerequisite for crrev.com/c/6501740 to
avoid painting a default background.

Also a transparent bubble should not apply rounded corners, since the
contents of a transparent TrayBubbleView handles its own rounded
corners.

Refactor: Instead of using TrayBubbleView::InitParams to specify the
radius BubbleBorder, we now use the BubbleDialogDelegate to configure
the bubble rounded corners.

[1]
https://source.chromium.org/chromium/chromium/src/+/main:ui/views/bubble/bubble_dialog_delegate_view.h;l=630;drc=4a1f2646209c5ecc0aae120e3654feb6d3f393f3

Bug: b:414655934
Change-Id: I5ee4724dbc5184a12eb7be6889ce7d026e434543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6541768
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Zoraiz Naeem <zoraiznaeem@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1459577}
1 file changed
tree: 047939c2f6fd1facd9db6bee08ad5f6f52cf8da2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.