| commit | 74116b04ff9a6299095784b50b7f60d91c183b8c | [log] [tgz] |
|---|---|---|
| author | Thomas Lukaszewicz <tluk@chromium.org> | Mon Sep 29 19:58:07 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 29 19:58:07 2025 |
| tree | f2c0be9aac0e081b3609ee15676eaab383507a18 | |
| parent | 203ecebaf55ab7a47e10f59a9a6033740c1fd936 [diff] |
[bedrock] Eliminate BrowserList::get() from //c/b/ part 3
This CL transitions clients of the BrowserList::get() API to more
appropriate APIs available in browser test environments.
This CL specifically focuses on removing remaining usage from
tab_restore_browsertest.cc.
- RestoreTab() is updated to take a target_browser instead of
an index into the BrowserList
- A null target_browser indicates a new browser is expected
to be created as the result of the restore
- RestoreGroup() is updated to take a target_browser instead of
an index into the BrowserList
- All clients only restore into an existing browser so
handling for new browsers was removed (simplifying the
code)
- The chrome::RestoreTab() browser_command was updated to take a
BrowserWindowInterface
- ui_test_utils::BrowserCreatedObserver was used to get references
to created browsers rather than indexing into an expected position
in the BrowserList
Bug: 431672609
Change-Id: I657ce9584a2dfee76360e85ff1b22c1c28422b08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6993569
Commit-Queue: Tom Lukaszewicz <tluk@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1522432}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.