commit 7418d6a22788a22d948fd8fc14b4835f639bb9be
author Eitan Goldberger <eitang@google.com> Thu Jul 18 11:24:58 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jul 18 11:24:58 2024
tree 4670b8db78705fc7b5e0842475ae89409e218904
parent bb5084c799f75ae55e470824d2931cb566cf62d8

Move language-menu to dom-if and restamp instead of lazy render.

This makes the dialog open automatically when the language-menu is
added to the DOM, and destroys the language menu when the dialog is
closed.

Previously, the language-menu was created once and was not torn down
throughout the life of the voice-menu. The language-menu component was
therefore in charge of showing/hiding the dialog and stayed alive even
when the dialog closed. This added significant complexity because the
language menu needed to differentiate between which property deps to
seed the list of the language menu vs the properties that needed to
live update the language menu. Also, this made the logic of keeping
track of notifications very complicated, because opening/closing
of the dialog needed to clear the notifications. Now, that logic is
not necessary, because the notifications are cleared automatically
when the dialog (and therefore the language menu) is closed.

The complication led to making the derived-props logic in the
lit-migration complicated. Additionally, it made it harder to optimize
the language menu to reduce glitching when it got live updates.

I removed the tests that track how the language-list is updated while
the dialog is closed, because this case is no longer applicable.

Bug: 352583619,40943652

Change-Id: I760dbff8cb8ec271297632011534569837691522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5713511
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Eitan Goldberger <eitang@google.com>
Cr-Commit-Position: refs/heads/main@{#1329436}