commit | 7464a7f5ba5465df98e488ce9a82295b4b7fdbb6 | [log] [tgz] |
---|---|---|
author | Scott Haseley <shaseley@chromium.org> | Thu Aug 10 16:48:08 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 10 16:48:08 2023 |
tree | 8ef3fcbd9288439893197d321b3669c0792c100f | |
parent | c3fec9a87f5fd33bc2063ff2fa8ff93b41be09bf [diff] |
Revert "[scheduler] Pass MainThreadTaskQueue by reference to OnTaskCompleted()" This reverts commit 6127010238603906be48080729aaa84705855077. Reason for revert: The queue can still be invalidated in microtasks because web scheduling TQs aren't gracefully shut down, which can cause crashes & UAFs. Original change's description: > [scheduler] Pass MainThreadTaskQueue by reference to OnTaskCompleted() > > Since graceful shutdown has been moved to the blink scheduler in > crrev.com/c/4349232, MainThreadTaskQueue is guaranteed to remain alive > while running tasks. As a follow-up, this CL changes OnTaskStarted(), > OnTaskCompleted(), and related methods to take a reference to MTTQ. This > also removes the "detached" queue type which was used in UKM as an > unknown type for detached queues. > > Bug: 1143007 > Change-Id: I849971d9e8bfdeadc757658a196bffa0dfb5de0d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605783 > Reviewed-by: Alexander Timin <altimin@chromium.org> > Commit-Queue: Scott Haseley <shaseley@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1176687} Bug: 1143007, 1470659 Change-Id: Ife7114ad68da586c28509026f01685538c848317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4769878 Commit-Queue: Scott Haseley <shaseley@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1182130}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.