commit 74b19b9ecaacce6b26b3a0f55b517897e078c060
author Illia Klimov <elklm@google.com> Fri May 07 13:03:32 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri May 07 13:03:32 2021
tree 613c9dd553e5f34e5f40aa3b129f3e80f48351bd
parent ef58734251e5b156be0cd73d966d2c883f277c21

Reland "Create and remove permission chip on demand."

This reverts commit 0dd008f10b6eadc4eee93790bd56238dbc6cc61c.

Reason for revert: Fixed broken tests.

Original change's description:
> Revert "Create and remove permission chip on demand."
>
> This reverts commit 89fce37d54770913a4c54d30cd2cf3d05f619f83.
>
> Reason for revert: Appears to have broken PermissionBubbleInteractiveUITest.SwitchTabs on linux-chromeos-chrome
>
> First failing build: https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/13979/overview
>
> Presumably OpenBubbleIfRequestChipUiIsShown fails because there is no chip.
>
> Original change's description:
> > Create and remove permission chip on demand.
> >
> > At the current moment, an instance of PermissionChip permanently exists
> > in LocationBarView. This CL changes that by creating and removing
> > PermissionChip on demand.
> >
> > Bug: 1177760
> > Change-Id: I98266fcfad1b5dd9a078629e892e2aa2e7628628
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2847352
> > Commit-Queue: Illia Klimov <elklm@chromium.org>
> > Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> > Reviewed-by: Olesia Marukhno <olesiamarukhno@google.com>
> > Cr-Commit-Position: refs/heads/master@{#879918}
>
> Bug: 1177760
> Change-Id: I325fbb575a36de85acec74d2a5d72ba7fccc38f8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2879637
> Auto-Submit: Timothy Loh <timloh@chromium.org>
> Owners-Override: Timothy Loh <timloh@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Timothy Loh <timloh@chromium.org>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#880262}

Bug: 1177760
Change-Id: I395bdf84b94d915f7227c2234d2dd530ba362da4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2879977
Reviewed-by: Olesia Marukhno <olesiamarukhno@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Illia Klimov <elklm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#880362}