| commit | 74e9da1850ff178b734ca11458c09d2ec794433c | [log] [tgz] |
|---|---|---|
| author | Javier Castro <jacastro@chromium.org> | Wed Oct 15 00:21:26 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Oct 15 00:21:26 2025 |
| tree | 4b1d55b8582981f3ef02969c502959b1849846cd | |
| parent | f825fa4cecb095b65a9d99a52c0135bc0d332ac8 [diff] |
Define ProcessSelectionUserData for ProcessSelectionDeferringCondition
Implementations of ProcessSelectionDeferringCondition, which are defined
by an embedder, need an extensible way to communicate information back
to the process selection logic. NavigationHandleUserData didn't work for
this use case because the navigation handle may not be available where
the process selection data is needed (like when SiteInfo gets created).
ProcessSelectionUserData solves this in a way that won't require making
further changes to the public definition nor further changes to
non-embedder data (such as UrlInfo). This change will allow the first
client, which will land in crrev.com/c/6897186 to communicate data back
to the process selection logic without needing to build additional
caching mechanisms.
This change works as follows:
1. We define a ProcessSelectionUserData that extends
base::SupportsUserData.
a. This serves as the container for the data and is added to a
NavigationRequest on construction.
b. We add a accessor function to NavigationHandle and provide that as
a convenience function on ProcessSelectionDeferringCondition so
that implementations of ProcessSelectionDeferringCondition know
that this data container is available.
c. UrlInfo is given a new field to hold the ProcessSelectionUserData.
The field is populated when the UrlInfo is created by
NavigationRequest::GetUrlInfo().
2. We define a ProcessSelectionUserData::Data that extends
base::SupportsUserData::Data.
a. Any ProcessSelectionDeferringCondition can define a data container
and extend ProcessSelectionUserData::Data to simplify data setting
and accessing. This is done in a manner similar to other user data
implementations such as WebContentsUserData.
b. The ProcessSelectionDeferringCondition can set this data on the
navigation_handle during its lifetime
3. The process selection logic can access the data later using
ProcessSelectionUserData::FromProcessSelectionUserData on the
appropriate data type.
Change-Id: Ic8530e02a9752b4ae7b3f3f013e2bde917069f73
Bug: 434009835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6974321
Commit-Queue: Javier Castro <jacastro@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1529877}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.