commit 75273e95cebeaa2dc999a2e614a4f04fc01458a5
author Andrés Olivares <andoli@chromium.org> Tue Feb 25 13:32:31 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Feb 25 13:32:31 2025
tree d638db598fe5ef722c4f7d85886b222f33093785
parent 255d2e13996b2d5a52830c7d1dfcda618d2beadd

Collect sample with trace id in inspector_trace_events::SetCallStack

This is a cheaper way to collect a stack trace at the moment a
trace event is dispatched (vs using CaptureSourceLocation, which
requires sync stack symbolization). We can use this stack trace data
to help us improve the trace events + cpu samples consolidation in the
Performance panel in DevTools.

As follow up work we should:

1. Use the helper in other events (e.g. performance.measure / mark)
2. Remove the usage of CaptureSourceLocation in the helper, since it is
considerably more expensive than collecting a marked sample and we
wouldn't need it now (if the risk/cost of breaking backwards compat is
low enough).

(see https://docs.google.com/document/d/1XTCUflYvxjHitBbnHeTzQQjipPIY4hilQ8iG06BilRk/edit?tab=t.0 for more context)

Bug: 396355813
Change-Id: I4330a38fb01b3551b36970942cc37fb605630c43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6288548
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424470}