commit 75724f9ef59bde263f68558ce3217eb127936698
author Greg Thompson <grt@chromium.org> Thu Mar 21 08:31:27 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Mar 21 08:31:27 2024
tree c30402afe546464481cd9257588fa6123b888e87
parent a8454841ab397df8e8df0ad15d9c5135440b334b

[test] Provide control of stack trace generation in tests

Collecting and emitting stack traces is not free. Tests that run in
debug configurations may time out solely due to this cost. There are
many cases in which stacks traces may never be visible to the developer.
One such case is in a death test's child proc: the child process is
expected to crash, so any stack traces generated for this are expected
and hidden.

In https://crrev.com/1246434 we suppressed the generation and printing
of stack traces in CHECK/LOG(FATAL)/etc messages in death tests. In
https://crrev.com/1272204 we replaced this with a change to `StackTrace`
itself to suppress output in any case in death tests. In this change, we
go one step further as follows:

By default, `base::debug::StackTrace` will no longer collect a trace in
a death test, and printing an empty stack trace will no longer do any
processing. Tests that require a stack trace in a death test may use
base::debug::OverrideStackTraceOutputForTesting to force-enable
generation and output of traces in death tests. Additionally, some
non-death tests may also result in the generation and emission of stack
traces that will never be seen (e.g., those that use
`EXPECT_FATAL_FAILURE`). These tests can use the same test helper to
suppress the generation and output of stack traces in non-death tests.

Bug: 41490321
Change-Id: I036e333ec66731ee125f2e80c2e05b002b339e7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5377866
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Alberto Juarez <albertojuarez@google.com>
Reviewed-by: Francois Pierre Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1276095}