commit 759508b448b43dff8ed5cbeb3f1d38638917f7a1
author François Doray <fdoray@chromium.org> Wed Oct 26 23:42:58 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Oct 26 23:42:58 2022
tree 1eb1fa2e1496bbfc33de9b2e2f2bca948e112817
parent 86f9c78964dd9cb0541966390f6934ff4b61cf38

Read BrowserPeriodicYieldingToNative params after FeatureList initialization.

The FeatureList is initialized after the construction of the
BrowserUIThreadScheduler and MessagePumpForUI:

  BrowserUIThreadScheduler: https://source.chromium.org/chromium/chromium/src/+/main:content/app/content_main_runner_impl.cc;l=1154;drc=e60bbf14121cbc814325dd222fec20d6a7a2a54c
    BrowserUIThreadScheduler::BrowserUIThreadScheduler
    BrowserTaskExecutor::Create

  MessagePumpForUI: https://source.chromium.org/chromium/chromium/src/+/main:content/app/content_main_runner_impl.cc;l=1154;drc=e60bbf14121cbc814325dd222fec20d6a7a2a54c
    MessagePumpForUI::MessagePumpForUI
    base::MessagePump::Create
    BrowserUIThreadScheduler::BrowserUIThreadScheduler
    BrowserTaskExecutor::Create

  FeatureList: https://source.chromium.org/chromium/chromium/src/+/main:content/app/content_main_runner_impl.cc;l=1163;drc=e60bbf14121cbc814325dd222fec20d6a7a2a54c
    FeatureList::SetInstance
    VariationsService::SetUpFieldTrials
    ChromeFeatureListCreator::SetUpFieldTrials
    ChromeFeatureListCreator::CreateFeatureList
    ChromeMainDelegate::PostEarlyInitialization

As a result, BrowserUIThreadScheduler and MessagePumpForUI currently
get the default values of the BrowserPeriodicYieldingToNative params,
instead of those overridden by the variations service or the command
line. This CL makes BrowserUIThreadScheduler and MessagePumpForUI
read the params after FeatureList initialization, so they get the
correct overridden values and to unblock this CL
https://crrev.com/c/3867967 which adds a DCHECK to prevent this
problem from happening again in the future.

(cherry picked from commit 253a306132ecfde6df9fc2cafe3cbada9191a118)

Bug: 1358639, 1215076
Change-Id: Ice12da8d42d68274db150887088dc7928ff2d6b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3949402
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Auto-Submit: Francois Pierre Doray <fdoray@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Francois Pierre Doray <fdoray@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1062857}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3984705
Reviewed-by: Francois Pierre Doray <fdoray@chromium.org>
Commit-Queue: Omar Elmekkawy <mekk@chromium.org>
Cr-Commit-Position: refs/branch-heads/5359@{#334}
Cr-Branched-From: 27d3765d341b09369006d030f83f582a29eb57ae-refs/heads/main@{#1058933}