Reland "Do not allow AXMode globals to get out of sync"

This is a reland of commit 39ee890c09e19ff020e5aee645cccf75b97bd57b
Reason for reland: undetected compile error after rebasing and landing.

Original change's description:
> Do not allow AXMode globals to get out of sync
>
> Currently, a global AXMode state is stored in both AXPlatformNode
> and BrowserAccessibilityStateImpl. This is dangerous, because
> they could get out of sync.
>
> A better, longer term fix would be to have a single global stored in
> ui/accessibility. We can do that in a second phase.
>
> - Discourage direct use of AXMode setters in AXPlatformNode. Only
>   BrowserAccessibilityStateImpl should be using those.
> - Remove ScopedAXMode from AXPlatform node so that browser tests are
>   not tempted to use it.
> - Add a DCHECK() to ensure the two states are in sync.
>
> This CL is a prerequisite for a follow-up CL, "Code cleanup in RenderFrameHostImpl", which had failing tests because of mismatched
> globals.
>
> Bug: None
> Change-Id: Ie90c3c756bca5ff41b411cd433a1628759f2aed4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823683
> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1039317}

Bug: None
Change-Id: I6cfb54e87f5dd51ae114707c9c96710bfd21c0ed
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3857785
Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1039708}
22 files changed
tree: 6d118a92a3915ae5d4f6b492846b43559865c80d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.