[SW+Prefetch] Check top frame origin/storage key of prefetch client Previously, when serving ServiceWorker-controlled prefetch, the `ServiceWorkerClient` for navigation uses the top frame origin and storage key of the `ServiceWorkerClient` for prefetch. However, storage keys are calculated using different code paths for prefetch and for navigation in `ServiceWorkerClient::CalculateStorageKeyForUpdateUrls()` and thus they can be theoretically different. This CL checks that the storage keys and top frame origins are the same for `ServiceWorkerClient`s for prefetch and navigation, and if they are actually different, stops serving from the prefetch, and `dumpWithoutCrashing` for further investigation. This CL merges `ServiceWorkerClient::InheritControllerFromPrefetch()` into `ServiceWorkerMainResourceHandle::InitializeForRequest()`, - To calculate the would-be storage key for navigation - To further unify the call sites of `ServiceWorkerClient::UpdateUrls()`. This CL shouldn't change the behavior other than stop serving from prefetch on actual storage key etc. mismatch, which doesn't occur in tests. Bug: 413207408 Change-Id: I9ce939970faa9a15f1e0c10bbc9094772a96ba1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581537 Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Cr-Commit-Position: refs/heads/main@{#1465317}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.