Google Git
Sign in
chromium / chromium / src / 765448cec1f672874f99804e150219c6dbbad43e
commit765448cec1f672874f99804e150219c6dbbad43e[log] [tgz]
authorAndrey Davydov <andreydav@google.com>Wed Jun 08 18:59:52 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 08 18:59:52 2022
treec5c18eb6d3dc2ec0864f9c50e6e17597d47203d1
parent4287812a17be9464c7197049b85f2f40186a3175 [diff]
[M103] Fix captive portal dialog placement on login screen

SimpleWebViewDialog was changed in [1] to use BoxLayout instead of
deprecated GridLayout. GridLayout used to look at the minimum size of
the host view, but BoxLayout uses preferred size instead. This
difference led to a wrong dialog position after the change (see
screenshots in the bug description). This cl fixes it.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/3570390

(cherry picked from commit ea125ed2de209f246cd97913d215312e8d89e42b)

Bug: 1328455
Test: manual with real captive portal network
Change-Id: Ice084d8c7073394bc70a0b04bf918e0100d66282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3684391
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrey Davydov <andreydav@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1009834}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3695260
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#689}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
2 files changed
tree: c5c18eb6d3dc2ec0864f9c50e6e17597d47203d1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.