commit 7690f3879655fe496fb369e558ac0235fe3ce266
author Aisulu Rakhmetullina <aisulu@google.com> Mon Mar 04 17:35:51 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 04 17:35:51 2024
tree 563c2ae0306099c7e3f1f0d7a4f5195eaa61c449
parent fde3225eb19e049b5127fc29c2ac01b99dc5ece0

[SHv2] Remove undo snack bar for 'Done' state

Safety Hub modules Unused Site Permissions and Notifications offer to
the user the list of origins for review and actions to take on them.
Each action currently is followed by 'Undo' snack bar. However, for
cases where the action leads to 'Done' state the 'Undo' snack bar is
redundant since the state already has the undo button itself.
This CL removes the snack bar for these scenarios.

Notifications module scenarios:
- Multiple/Single origin(s) for review -> Click 'Block All'
- Single origin for review -> Click 'Block'/'Allow'/'Reset'

Unused Site Permissions module:
- Multiple/Single origin(s) for review -> Click 'Got it'
- Single origin for review -> Click 'Allow again'

While at it, fix a few things for Notifications module
'Single origin for review' -> click 'Block all' case. Namely:
- Fix the wrong metric value recording. Namely, 'Undo' button click results in recording .UNDO_BLOCK instead of .UNDO_BLOCK_ALL enum value.
- Fix the snack bar and the 'Done' state header strings.

Potentially this also fixes the issues in b/41483087.

Bug: 1443466
Fixed: 1510537, 1517702, 1517705
Recording: http://dr/file/d/1jMTMp1cVGssBVTDEE7l2IPr2onOMcMuj/view
Change-Id: Ia6f089dc1b7c6a51bdf4db02f17750f48970bc25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5177396
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Aisulu Rakhmetullina <aisulu@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Rainhard Findling <rainhard@chromium.org>
Reviewed-by: Side YILMAZ <sideyilmaz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1267920}