Google Git
Sign in
chromium / chromium / src / 769dd3abdc6f6e994ec59503abc1d3e2e3d822c1
commit769dd3abdc6f6e994ec59503abc1d3e2e3d822c1[log] [tgz]
authorspdonghao <spdonghao@chromium.org>Fri May 27 04:57:38 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 27 04:57:38 2022
treef6049e891054960ced538f4b1d955a2c30fe220e
parent0954174da97ec322607365fe776853cd74a3df25 [diff]
[Start] Fix the closing tab animation in grid tab switcher surface.

When we switch to grid tab switcher surface from start surface,
#prepareTabSwitcherView won't be called since it's not a layout change.
So |mOriginalAnimator| is not initialized and closing tab animation is
not shown.
This CL adds a null check for |mOriginalAnimator| to fix this problem.

Before:
https://drive.google.com/file/d/1am7UfBY_7VY8BCuBStyI9sCxhfnvoKUA/view?usp=sharing&resourcekey=0-DuOCztQLuQPGjZw3n9aqSw
After:
https://drive.google.com/file/d/1PbiNL6OfBTxEBFhk246qeT1kglDpwzk_/view?usp=sharing&resourcekey=0-vcPbhEzFheDHy-JaAysfaQ

(cherry picked from commit deeb0072ed817af70f0faa077d0e4f24c30ebbc2)

Bug: 1200882
Change-Id: I6372b9dceeaaa5ec78cfef70cee0d972b13b5d2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3664819
Reviewed-by: Mei Liang <meiliang@chromium.org>
Commit-Queue: Hao Dong <spdonghao@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1007646}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3669600
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Owners-Override: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#289}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
1 file changed
tree: f6049e891054960ced538f4b1d955a2c30fe220e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.