commit | b78ddd0d63c18e7524977eb2827ce0b53d20e3ca | [log] [tgz] |
---|---|---|
author | Wenbo Jie <wenbojie@chromium.org> | Mon May 09 06:23:40 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon May 09 06:23:40 2022 |
tree | 04d66cd6d48ba82e9d8e18b9f94a8659c518079f | |
parent | 30ccf8ea0fa4a7def16407dafb2f2ca69575b6b8 [diff] |
Reland "[FilesRecentFilter] Documents filter for ARC" This is a reland of commit 26edf35011ec88154318e2adbb2f0726ea68b8a9. The original revert was related to a test failure in VolumeManager, the root cause is the assertion of "event.success" is not available on Msan platform. In this reland, the assertion of "event.success" is being removed, check the diff between patchset 1 and patchset 2. Also, 2 Msan related try jobs have been added to presubmit check to make sure the change works. Original change's description: > [FilesRecentFilter] Documents filter for ARC > > Support documents_root in RecentArcMediaSource: > * Add documents_root to the arc_documents_provider. > * Register the new root in the volume_manager. > * Refactor: remove all hard-code root string and use constants from > arc_media_view_util. > > Note: this feature only works with ARCVM (android 11), because that's > when Android's MediaDocumentsProvider.queryRecentDocuments() > introduces documents_root support. For ARC++ containers, no files will > return for documents_root. > > Demo: http://shortn/_ezNIvqcryC > Demo for Android 9: http://shortn/_4Xooka3i1J (image/video filters still > work, but the document file .doc is not showing in the All/Documents > filter) > > folders and restart chromebook, then check the newly created files > should appear in Recents document filter > > Bug: 881673 > Test: unit_tests --gtest_filter="*RecentArcMediaSourceTest*" > Test: unit_tests --gtest_filter="*VolumeManagetTest*" > Test: unit_tests --gtest_filter="*FileManagerPathUtilTest*" > Test: manually create doc files (e.g. txt/pdf/doc) in the "Play files" > Change-Id: I98679e48c59560799deb05bbf9351885e9157079 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3596676 > Commit-Queue: Wenbo Jie <wenbojie@chromium.org> > Reviewed-by: Austin Tankiang <austinct@chromium.org> > Reviewed-by: David Jacobo <djacobo@chromium.org> > Cr-Commit-Position: refs/heads/main@{#999778} Bug: 881673 Change-Id: I67f29fc795af3af16bbcf6c8dbcc659a89b79841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3631739 Reviewed-by: Austin Tankiang <austinct@chromium.org> Commit-Queue: Wenbo Jie <wenbojie@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1000884}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.